emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Problem with PCL-CVS


From: David Kastrup
Subject: Re: Problem with PCL-CVS
Date: Wed, 16 Aug 2006 01:31:44 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

David Kastrup <address@hidden> writes:

> Stefan Monnier <address@hidden> writes:
>
>>> Whenever a file gets deleted in the repository, and I do
>>> M-x cvs-examine RET /home/devel/emacs RET
>>
>>> then the file gets listed as removed in the status display with
>>> additional `...' quote marks around it.
>>
>> Hmm, I haven't seen this yet.  Can you show me the "*cvs*" buffer and the
>> corresponding " *cvs-tmp*" right after the offending cvs-examine command?
>
> There you are: I don't understand how you can't see it.  Do
> M-x cvs-status RET /your/working-copy RET
>
> Move to one line showing "Removed", press "O".  Very annoying.  This
> is the result; of course all the "Up-To-Date" marks are wrong.
> Nothing has been updated.

[...]

This particular problem gets fixed at my site with the following
patch:

*** pcvs-parse.el       02 May 2006 12:55:47 +0200      1.27
--- pcvs-parse.el       15 Aug 2006 08:42:38 +0200      
***************
*** 285,291 ****
         (and
        (cvs-or
         (cvs-match "warning: \\(.*\\) is not (any longer) pertinent$" (file 1))
!        (cvs-match "\\(.*\\) is no longer in the repository$" (file 1)))
        (cvs-parsed-fileinfo
         (if dont-change-disc '(NEED-UPDATE . REMOVED) 'DEAD) file))
  
--- 285,291 ----
         (and
        (cvs-or
         (cvs-match "warning: \\(.*\\) is not (any longer) pertinent$" (file 1))
!        (cvs-match "`\\(.*\\)' is no longer in the repository$" (file 1)))
        (cvs-parsed-fileinfo
         (if dont-change-disc '(NEED-UPDATE . REMOVED) 'DEAD) file))
  
However, the vicinity of the patch looks like similar problems might
occur with other expressions.  Maybe `cvs-match' or a specific similar
routine created for this purpose should instead be made to strip
quoting character pairs (I would think it conceivable that some CVS
clients might use utf-8 quoting characters in appropriate locales),
and the general patterns should not specify quotes at all.

I have no knowledge of CVS clients and their quoting history, however,
so I have no idea whether that would be a sensible thing to do.

I can check in the above patch if nobody objects: it is, at least for
my CVS client, an improvement.  Stefan, can you run "strings" on your
client to see whether it would be the same with yours?  After all, you
claimed that you could not see the effect.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

reply via email to

[Prev in Thread] Current Thread [Next in Thread]