[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: local keymap patch for key-binding

From: Richard Stallman
Subject: Re: local keymap patch for key-binding
Date: Wed, 13 Sep 2006 15:25:05 -0400

Why add the argument LOCATION?  Is it just for the sake of

Why the need to switch buffers?

Aside from that, some little details:

    +   * keymap.c: include "window.h".

You need to add a dependency in Makefile.in for that.

    !       if (SYMBOLP (AREF(location,0)) && ASIZE(location) > 1)
    !   event = AREF(location,1);
    !       else
    !   event = AREF(location,0);

To follow our coding style you need additional spaces here:

    !       if (SYMBOLP (AREF (location,0)) && ASIZE (location) > 1)
    !   event = AREF (location, 1);
    !       else
    !   event = AREF (location, 0);

A comma should always be followed by a space.
Outside of a parenthesis there must be a space,
unless the same spot is inside another parenthesis
or followed by a semicolon.

There needs to be documentation for LOCATION in etc/NEWS and the Lisp

    !     /* Key sequences beginning with mouse clicks are
    !        read using the keymaps in the buffer clicked on,
    !        not the current buffer.  If we're at the
    !        beginning of a key sequence, switch buffers.  */

I can't understand the second sentence, "If we're at the beginning of
a key sequence".  Since key-binding always operates on a key sequence,
and since we're not in the middle of a loop which scans that key
sequence, what does it mean to say that we are, or are not, "at the
beginning" of it?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]