[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: vc-dired

From: Masatake YAMATO
Subject: Re: vc-dired
Date: Sat, 28 Jul 2007 16:06:06 +0900 (JST)

> Stefan Monnier <address@hidden> writes:
>   > >> I was interested in merge DVC to GNU Emacs. However, these days, I am
>   > >> busy and I get interests to extend vc-dired, so I've just asked DVC
>   > >> developers to assign another people for working on the merging task.
>   > 
>   > > Given that you are interested in vc-dired, can you please look into
>   > > these issues: 
>   > 
>   > > - pass --ignore= to ls so that it does not recurse into things like
>   > >   .svn directories
>   > 
>   > At least the vc.el part of VC should simply not use `ls' or any such thing
>   > and shouldn't recurse into directories.  It should simply ask the backend 
> to
>   > do it (the backend can then use "cvs -n update" or "svn status" ...).
>   > That'll be blindingly faster.
> I would go even farther, IMVHO the "dired" part of the interface for
> vc-dired is not that useful: the 4 top-level menu entries are not very
> useful in the VC context, there's no top level menu for VC operations
> and the files not under VC are not shown by default (it would be good
> to see them so they can be vc-registered if desired).
> It seems to me that a cvs-status like UI would be preferable to
> vc-dired.

Here is the first very small patch.
Do you think menu item "Version Control" is too long? 
"VC" is better?

Reorganizing the the 4 top-level is not done yet. I think we have to 
think about integrating version control own command and the menu entries.

     svn rm and "Operate"=>"Rename To" menu item.

In a directory which is version-control'ed by svn, vc-dired user may
expect "svn rm" is run when s/he invoke "Operate"=>"Rename To" menu

Index: vc.el
RCS file: /sources/emacs/emacs/lisp/vc.el,v
retrieving revision 1.444
diff -c -F define-derived-mode -r1.444 vc.el
*** vc.el       26 Jul 2007 18:44:37 -0000      1.444
--- vc.el       28 Jul 2007 06:59:09 -0000
***************   ;; define-derived-mode does it for us 
*** 2192,2197 ****
--- 2192,2201 ----
    ;; We do it here because dired might not be loaded yet
    ;; when vc-dired-mode-map is initialized.
    (set-keymap-parent vc-dired-mode-map dired-mode-map)
+   ;; Add menu after `vc-dired-mode-map' has `dired-mode-map' as the parent.
+   (let ((vc-dire-menu-map (copy-keymap vc-menu-map)))
+     (define-key-after (lookup-key vc-dired-mode-map [menu-bar]) [vc] 
+       (cons "Version Control" vc-dire-menu-map) 'subdir))
    (add-hook 'dired-after-readin-hook 'vc-dired-hook nil t)
    ;; The following is slightly modified from files.el,
    ;; because file lines look a bit different in vc-dired-mode

reply via email to

[Prev in Thread] Current Thread [Next in Thread]