Re: Emacs 22.1 reproducible crash

[Gardner Bell]

--- Giorgos Keramidas <address@hidden> wrote:

> On 2007-08-08 13:00, Giorgos Keramidas <address@hidden> wrote:
> >On 2007-08-08 11:32, YAMAMOTO Mitsuharu
> <address@hidden> wrote:
> >>>>>>> On Tue, 07 Aug 2007 14:03:51 +0200, Jan Dj?rv
> <address@hidden> said:
> >>>> Same thing, slightly different backtrace this time.  I have also
> >>>> noticed that this is triggered much easier when using the mouse
> to
> >>>> open, and close files.
> >>>
> >>> I think this might be due to the fact that Glib uses
> posix_memalign,
> >>> but there is no posix_memalign in gmalloc.c.
> >>
> >> Then adding its implementation to gmalloc.c simply work?
> >>
> >> Index: src/gmalloc.c
> >>
> ===================================================================
> >> RCS file: /cvsroot/emacs/emacs/src/gmalloc.c,v
> >> retrieving revision 1.25
> >> diff -c -p -r1.25 gmalloc.c
> >> *** src/gmalloc.c  7 Aug 2007 08:55:43 -0000       1.25
> >> --- src/gmalloc.c  8 Aug 2007 02:31:42 -0000
> >> *************** memalign (alignment, size)
> >> *** 1857,1862 ****
> >> --- 1857,1891 ----
> >>     return result;
> >>   }
> >>
> >> + #ifndef ENOMEM
> >> + #define ENOMEM 12
> >> + #endif
> >> +
> >> + #ifndef EINVAL
> >> + #define EINVAL 22
> >> + #endif
> >> +
> >> + int
> >> + posix_memalign (memptr, alignment, size)
> >> +      __ptr_t *memptr;
> >> +      __malloc_size_t alignment;
> >> +      __malloc_size_t size;
> >
> > Excellent, thanks :-)
> >
> > I will try this with a snapshot of HEAD from CVS in a few minutes
> :-)
> 
> Nice.  I just finished rebuilding Emacs --with-gtk from a snapshot of
> the CVS repository at:
> 
> % changeset:   82488:9563c0c734fe
> % tag:         tip
> % user:        gm
> % date:        Wed Aug 08 08:14:03 2007 +0000
> % files:       lisp/emacs-lisp/eldoc.el
> % description:
> % (eldoc-get-fnsym-args-string): Make second argument optional, for
> % backwards compatibility, and only highlight args when present.
> % Fix symbol name typo (doc/args).
> 
> A clean bootstrap now works as expected (i.e. no temacs crash while
> building), and I haven't been able to crash Emacs in the first few
> minutes by browsing news groups with Gnus (this used to trigger a
> segfault pretty fast before).
> 
> I think we may have a fix, but let's wait until Jan completes his own
> testing too :-)
> 
> Thank you for the patch,
> George
> 
> 

Emacs is now working quite well on this side as well with your latest
patch to gmalloc.c.  Thanks to everyone that helped work on this patch.
It has been greatly appreciated.