[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: C-x v l does not move to current log entry
From: |
Stefan Monnier |
Subject: |
Re: C-x v l does not move to current log entry |
Date: |
Fri, 10 Aug 2007 04:09:26 -0400 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) |
> This turns out to be coming from log-view-font-lock-keywords, which has
> a value that looks something like this:
> ((eval \` (\,log-view-file-re (1 ...) (0 log-view-file-face append)))
> (eval \` (\,log-view-message-re . log-view-message-face)))
> The source (log-view.el:170) specifies backquoted forms inside a quoted
> form; it appears that the reader is not handling this correctly. The
> attached patch replaces the backquotes with explicit "cons" calls; this
> is not a real fix, and I include it only to show that it does make the
> error messages go away. Fixing the reader is undoubtedly hairier.
It turns out that the handling of nested backquotes was simply not working.
The reader's treatment worked (although IIRC it only works since Emacs-21),
but the backquote expansion was flawed. As for the above bug it comes from
an incorrect treatment of the new backquote style (and its nesting) in the
printer (used by the byte-compiler, hence the above problem only appeared
when using log-view.elc rather than log-view.el which is why it worked fine
when I wrote the code).
I believe I've now fixed both problems in the 22 branch (should be merged into
the trunk in a couple days).
Stefan "Duh!"
- C-x v l does not move to current log entry, Jan Djärv, 2007/08/01
- Re: C-x v l does not move to current log entry, Richard Stallman, 2007/08/02
- Re: C-x v l does not move to current log entry, Bob Rogers, 2007/08/03
- Re: C-x v l does not move to current log entry, Richard Stallman, 2007/08/04
- Re: C-x v l does not move to current log entry,
Stefan Monnier <=
- Re: C-x v l does not move to current log entry, Richard Stallman, 2007/08/12
- Re: C-x v l does not move to current log entry, Jan Djärv, 2007/08/12
- Re: C-x v l does not move to current log entry, Stefan Monnier, 2007/08/12
- Re: C-x v l does not move to current log entry, Jan Djärv, 2007/08/13