emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bug of display-table & make-glyph-code


From: martin rudalics
Subject: Re: bug of display-table & make-glyph-code
Date: Thu, 06 Sep 2007 10:49:27 +0200
User-agent: Mozilla Thunderbird 1.0 (Windows/20041206)

> Well, that's easy. :)  I say; install your dired-warning fix, and cross
> this off the list.

Mapping dired-warning to font-lock-warning-face was a bad idea: The
latter is already used for marking and flagging.  It seems better to use
`font-lock-comment-delimiter-face' just for the min-colors 8 case as in
the patch below.

*** dired.el.~1.359.2.6.~       Tue Aug  7 16:01:52 2007
--- dired.el    Thu Sep  6 10:34:06 2007
***************
*** 335,341 ****
    "Face name used for flagged files.")

  (defface dired-warning
!   '((t (:inherit font-lock-comment-face)))
    "Face used to highlight a part of a buffer that needs user attention."
    :group 'dired-faces
    :version "22.1")
--- 335,343 ----
    "Face name used for flagged files.")

  (defface dired-warning
!   '((((class color) (min-colors 16)) (:inherit font-lock-comment-face))
!     (((class color) (min-colors 8)) (:inherit 
font-lock-comment-delimiter-face))
!     (t (:inherit font-lock-comment-face)))
    "Face used to highlight a part of a buffer that needs user attention."
    :group 'dired-faces
    :version "22.1")





reply via email to

[Prev in Thread] Current Thread [Next in Thread]