emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: diff-sanity-check-hunk fails on "unterminated" hunks


From: Bob Rogers
Subject: Re: diff-sanity-check-hunk fails on "unterminated" hunks
Date: Wed, 12 Sep 2007 22:04:50 -0400

   From: Bob Rogers <address@hidden>
   Date: Wed, 12 Sep 2007 08:09:25 -0400

      From: Stefan Monnier <address@hidden>
      Date: Wed, 12 Sep 2007 01:09:38 -0400

      . . .

      Does the patch below address your particular problem (which I agree is
      a case that should be handled, I've encountered it several times already,
      tho that was before implementing diff-sanity-check-hunk, obviously).

              Stefan

   This looks like it ought to work, and does seem more robust; I will test
   it later today (no time now).  But I'm a bit concerned about the effect
   of silently adding a newline; this will fail mysteriously if the diff is
   read-only.

It works for me, but I still have reservations about modifying the
buffer.  It modifies the buffer successfully even if I have the
read-only bit set -- how does it do this?  But then I can't undo it
without doing C-x C-q first . . .

                                        -- Bob




reply via email to

[Prev in Thread] Current Thread [Next in Thread]