Re: Please install and ack

[Jason Rumney]

Johannes Weiner wrote:
>> --- src/xterm.c.orig 2007-05-25 12:43:35.000000000 +0000
>> +++ src/xterm.c      2007-08-31 03:43:32.106444418 +0000
>>  
>> +#ifndef abs
>>  #define abs(x)      ((x) < 0 ? -(x) : (x))
>> +#endif
>>     

> Wouldn't it be better to centralize that macro?  It's trivial, sure.  But
> repetition is not beautiful.

Rather than centralising it, which has caused problems with at least one
compiler due to the order of includes, and the fact that the system
headers do not protect against redefinition with an #ifdef abs, wouldn't
it be better to include <stdlib.h> in those files that require it?