[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: verilog-mode.el
From: |
Dan Nicolaescu |
Subject: |
Re: verilog-mode.el |
Date: |
Sun, 14 Oct 2007 10:49:43 -0700 |
Michael McNamara <address@hidden> writes:
Thank you for your contribution:
>
> ;; verilog-mode.el --- major mode for editing verilog source in Emacs
> ;;
> ;; $Id: verilog-mode.el 366 2007-10-07 13:20:47Z mac $
Keyword expansion frowned on in emacs CVS, it generates unnecessary
conflicts...
> ;; This variable will always hold the version number of the mode
> (defconst verilog-mode-version (substring "$$Revision: 366 $$" 12 -3)
> "Version of this verilog mode.")
> (defconst verilog-mode-release-date (substring "$$Date: 2007-10-07 06:20:47
-0700 (Sun, 07 Oct 2007) $$" 8 -3)
> "Version of this verilog mode.")
Same here.
> (defvar verilog-mode-map ()
> "Keymap used in Verilog mode.")
> (if verilog-mode-map
> ()
> (setq verilog-mode-map (make-sparse-keymap))
> (define-key verilog-mode-map ";" 'electric-verilog-semi)
Better use:
(defvar verilog-mode-map
(let ((map (make-sparse-keymap)))
(define-key map ";" 'electric-verilog-semi)
... etc etc
Please look at the byte-compile warnings, most of them are easily
fixable.