Re: unicode build: "comparison is always true" warnings

[Andreas Schwab]

Jan Djärv <address@hidden> writes:

> The patch just needs some small changes:
>
>
> *** movemail.c.~1.88.~  2007-07-27 09:52:07.000000000 +0200
> --- movemail.c  2007-11-24 14:07:13.000000000 +0100
> ***************
> *** 324,338 ****
> --- 324,345 ----
>         while (p != tempname && !IS_DIRECTORY_SEP (p[-1]))
>         p--;
>         *p = 0;
> + #ifndef HAVE_MKSTEMP
>         strcpy (p, "EXXXXXX");
>         mktemp (tempname);
>         unlink (tempname);
> + #endif
>
>         while (1)
>         {
>           /* Create the lock file, but not under the lock file name.  */
>           /* Give up if cannot do that.  */
> + #ifndef HAVE_MKSTEMP
>           desc = open (tempname, O_WRONLY | O_CREAT | O_EXCL, 0666);
> + #else
> +           strcpy (p, "EXXXXXX");
> +           desc = mkstemp (tempname);
> + #endif
>           if (desc < 0)
>             {
>               char *message = (char *) xmalloc (strlen (tempname) + 50);

I'd suggest moving the mktemp into the loop as well.  This will avoid
code duplication.

Andreas.

-- 
Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."