[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: State of VC?

From: Dan Nicolaescu
Subject: Re: State of VC?
Date: Wed, 23 Jan 2008 23:07:19 -0800

Glenn Morris <address@hidden> writes:

  > Dan Nicolaescu wrote:
  > > Pointers? 
  > > I only remember one bug:
  > > http://permalink.gmane.org/gmane.emacs.devel/87064
  > Links to VC-related issues that are unaddressed AFAIK. Some of them
  > may well be dealt with - you will know better than I.
  > strange window behavior from vc-diff
  > http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01276.html

The problem here is indeed in vc-diff-sentinel. It calls 
which does this:
  (when (null window)
    (setq window (selected-window)))

So it will look at (selected-window), so it will shrink the wrong
Not sure what the best solution is here.

  > vc-dired refresh
  > http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01268.html

This is for vc-dired. Needs to be looked checked if it still happens
when vc-dired is replaced with vc-status.

  > Patch: vc-dired-hook -vs- vc-call
  > http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg00549.html
  > Further VC tuning is blocked
  > http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg00410.html

Already replied about these in another message.

  > strange byte compiler behavior
  > http://lists.gnu.org/archive/html/emacs-devel/2007-12/msg01356.html
  > vc.el complaint about reference to free variable `file'
  > http://lists.gnu.org/archive/html/emacs-devel/2007-12/msg00872.html

Still need fixing.

  > wrong behaviour of vc-workfile-unchanged-p
  > http://lists.gnu.org/archive/html/emacs-devel/2007-12/msg00867.html

The analysis in the bug report seems correct.
Opinions on this patch?
(this code has been around for a long time...)

--- vc-hooks.el.~1.220.~2008-01-13 10:45:01.000000000 -0800
+++ vc-hooks.el2008-01-23 23:01:02.000000000 -0800
@@ -558,10 +558,11 @@
     (if (and checkout-time
              ;; Tramp and Ange-FTP return this when they don't know the time.
              (not (equal lastmod '(0 0))))
-        (equal checkout-time lastmod)
-      (let ((unchanged (vc-call workfile-unchanged-p file)))
-        (vc-file-setprop file 'vc-checkout-time (if unchanged lastmod 0))
-        unchanged))))
+        (if (equal checkout-time lastmod)
+    t
+  (let ((unchanged (vc-call workfile-unchanged-p file)))
+    (vc-file-setprop file 'vc-checkout-time (if unchanged lastmod 0))
+    unchanged)))))
 (defun vc-default-workfile-unchanged-p (backend file)
   "Check if FILE is unchanged by diffing against the master version.

  > address@hidden: vc-sccs-workfile-version returns wrong version number]
  > http://lists.gnu.org/archive/html/emacs-devel/2007-11/msg01572.html

No idea.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]