[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: featurep instead of bound tests (was: Changes to emacs/lisp/gnus/Cha
From: |
Dan Nicolaescu |
Subject: |
Re: featurep instead of bound tests (was: Changes to emacs/lisp/gnus/ChangeLog, v) |
Date: |
Thu, 24 Jan 2008 13:55:09 -0800 |
Reiner Steib <address@hidden> writes:
> On Thu, Jan 24 2008, Dan Nicolaescu on emacs-diffs:
>
> > --- gnus/ChangeLog 24 Jan 2008 07:47:37 -0000 1.633
> > +++ gnus/ChangeLog 24 Jan 2008 15:14:50 -0000 1.634
> > @@ -1,3 +1,9 @@
> > +2008-01-24 Dan Nicolaescu <address@hidden>
> > +
> > + * sieve.el (sieve-make-overlay, sieve-overlay-put, sieve-overlays-at):
> > + * message.el (message-beginning-of-line): Use featurep instead of bound
> > + tests in order to resolve conditionals at compile time.
>
> In the past, I've been told that it's preferable to use fbound tests
> instead of Emacs flavor or version tests. So I'm surprised by changes
> like these...
In general probably yes, but these particular cases are about functions
that emacs will probably never get because it has similar facilities:
overlays vs extents.
> > --- gnus/sieve.el 8 Jan 2008 20:45:19 -0000 1.12
> > +++ gnus/sieve.el 24 Jan 2008 15:14:49 -0000 1.13
> > @@ -290,15 +290,15 @@
> > (get-char-property (or pos (point)) 'script-name))
> >
> > (eval-and-compile
> > - (defalias 'sieve-make-overlay (if (fboundp 'make-overlay)
> > - 'make-overlay
> > - 'make-extent))
> > - (defalias 'sieve-overlay-put (if (fboundp 'overlay-put)
> > - 'overlay-put
> > - 'set-extent-property))
> > - (defalias 'sieve-overlays-at (if (fboundp 'overlays-at)
> > - 'overlays-at
> > - 'extents-at)))
> > + (defalias 'sieve-make-overlay (if (featurep 'xemacs)
> > + 'make-extent
> > + 'make-overlay))
> > + (defalias 'sieve-overlay-put (if (featurep 'xemacs)
> > + 'set-extent-property
> > + 'overlay-put))
> > + (defalias 'sieve-overlays-at (if (featurep 'xemacs)
> > + 'extents-at
> > + 'overlays-at)))
>
> Bye, Reiner.
> --
> ,,,
> (o o)
> ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/