Re: autoconf bcopy and bzero

[Dan Nicolaescu]

Tom Tromey <address@hidden> writes:

  > >>>>> "Dan" == Dan Nicolaescu <address@hidden> writes:
  > 
  > Dan> uclibc uses #define to define bcopy and bzero in <strings.h>
  > Dan> emacs' configure script decides that bcopy and bzero are not available
  > Dan> and then #defines them in config.h. 
  > 
  > Can you look in your config.log to see why the existing bcopy test
  > failed?  I think it should work ok.

The autoconf test does not include <strings.h>, so it can't see
definitions for bzero/bcopy. 

config.h does include <strings.h>


  > Dan> In file included from frame.c:22:
  > Dan> ./config.h:1159:1: warning: "bcopy" redefined
  > Dan> In file included from ./config.h:1096,
  > Dan>                  from frame.c:22:
  > Dan> /usr/include/string.h:329:1: warning: this is the location of the
  > Dan> previous definition
  > 
  > One way to get rid of the warning is to '#undef bcopy' before defining
  > it.  Alternatively, the code could read:
  > 
  >     #if !defined HAVE_BCOPY && !defined bcopy
  >     #define bcopy(a,b,s) memcpy (b,a,s)
  >     #endif

That's the obvious think to do, but is it correct?