emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 23.0.50; ielm doesn't handle comments


From: Lawrence Mitchell
Subject: Re: 23.0.50; ielm doesn't handle comments
Date: Fri, 15 Feb 2008 19:44:30 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (darwin)

Bastien Guerry wrote:
> Bastien Guerry <address@hidden> writes:

>>> I think the right way to fix this is to allow ielm to read the
>>> form as it currently does (using read-from-string) and then
>>> discard following input if it contains either merely whitespace
>>> (as is currently the case) or a comment.

>> I will apply this with the ChangeLog you provided if you agree.

> Applied.

I realise the patch I sent didn't fix the docstring of
ielm-is-whitespace-or-comment correctly.  How about this:

diff --git a/lisp/ielm.el b/lisp/ielm.el
index a925558..5e1921e 100644
--- a/lisp/ielm.el
+++ b/lisp/ielm.el
@@ -301,7 +301,7 @@ simply inserts a newline."
 ;;; Utility functions
 
 (defun ielm-is-whitespace-or-comment (string)
-  "Return non-nil if STRING is all whitespace."
+  "Return non-nil if STRING is all whitespace or a comment."
   (or (string= string "") 
       (string-match "\\`[ \t\n]*\\(?:;.*\\)*\\'" string)))
 

ChangeLog:

Lawrence Mitchell <address@hidden>

         * ielm.el (ielm-is-whitespace-or-comment): Docstring
           fix.

Cheers,

Lawrence
-- 
Lawrence Mitchell <address@hidden>





reply via email to

[Prev in Thread] Current Thread [Next in Thread]