[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Octave Help Mode?
From: |
David Hansen |
Subject: |
Re: Octave Help Mode? |
Date: |
Tue, 15 Apr 2008 20:21:18 +0200 |
User-agent: |
Gnus/5.110009 (No Gnus v0.9) Emacs/23.0.60 (gnu/linux) |
On Tue, 15 Apr 2008 11:55:17 -0400 Stefan Monnier wrote:
>> Is there any need for `octave-help' if `info-lookup-symbol' is doing
>> the same (as far as I can see)?
>
> I haven't looked at octave-help, but maybe it is indeed redundant.
> Can someone check?
Well, I just did. It does indeed nothing more than `info-lookup-symbol'.
I suggest to remove octave-hlp.el and applying the attached patch. But
it can't hurt to wait a bit and give the maintainer a chance to have his
word.
David
*** octave-mod.el.~1.44.~ 2008-02-17 01:40:24.000000000 +0100
--- octave-mod.el 2008-04-15 20:13:12.000000000 +0200
***************
*** 31,44 ****
;; It defines Octave mode, a major mode for editing
;; Octave code.
- ;; The file octave-hlp.el provides `octave-help', a facility for looking up
- ;; documentation on a symbol in the Octave info files.
-
;; The file octave-inf.el contains code for interacting with an inferior
;; Octave process using comint.
! ;; See the documentation of `octave-mode', `octave-help' and
! ;; `run-octave' for further information on usage and customization.
;;; Code:
(require 'custom)
--- 31,41 ----
;; It defines Octave mode, a major mode for editing
;; Octave code.
;; The file octave-inf.el contains code for interacting with an inferior
;; Octave process using comint.
! ;; See the documentation of `octave-mode' and `run-octave' for further
! ;; information on usage and customization.
;;; Code:
(require 'custom)
***************
*** 224,230 ****
(define-key map "\C-c\M-\C-h" 'octave-mark-block)
(define-key map "\C-c]" 'octave-close-block)
(define-key map "\C-c\C-f" 'octave-insert-defun)
! (define-key map "\C-c\C-h" 'octave-help)
(define-key map "\C-c\C-il" 'octave-send-line)
(define-key map "\C-c\C-ib" 'octave-send-block)
(define-key map "\C-c\C-if" 'octave-send-defun)
--- 221,227 ----
(define-key map "\C-c\M-\C-h" 'octave-mark-block)
(define-key map "\C-c]" 'octave-close-block)
(define-key map "\C-c\C-f" 'octave-insert-defun)
! (define-key map "\C-c\C-h" 'info-lookup-symbol)
(define-key map "\C-c\C-il" 'octave-send-line)
(define-key map "\C-c\C-ib" 'octave-send-block)
(define-key map "\C-c\C-if" 'octave-send-defun)
***************
*** 283,289 ****
["Submit Bug Report" octave-submit-bug-report t]
"-"
["Describe Octave Mode" octave-describe-major-mode t]
! ["Lookup Octave Index" octave-help t])
"Menu for Octave mode.")
(defvar octave-mode-syntax-table
--- 280,286 ----
["Submit Bug Report" octave-submit-bug-report t]
"-"
["Describe Octave Mode" octave-describe-major-mode t]
! ["Lookup Octave Index" info-lookup-symbol t])
"Menu for Octave mode.")
(defvar octave-mode-syntax-table
***************
*** 1517,1523 ****
'octave-comment-char
'octave-continuation-offset
'octave-continuation-string
- 'octave-help-files
'octave-send-echo-input
'octave-send-line-auto-forward
'octave-send-show-buffer))))
--- 1514,1519 ----