[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Build failure on M$ (using MSVC): Patch enclosed

From: Jason Rumney
Subject: Re: Build failure on M$ (using MSVC): Patch enclosed
Date: Tue, 20 May 2008 10:46:20 +0100
User-agent: Thunderbird (Windows/20080421)

dhruva wrote:
The below patch fixes the bug of infinite looping.

diff --git a/lisp/files.el b/lisp/files.el
index ee5efe4..c680d32 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -3120,8 +3120,9 @@ If the file is in a registered project, a cons from
 `project-directory-alist' is returned.
 Otherwise this returns nil."
   (let ((dir (file-name-directory file))
+       (root (expand-file-name "/"))
        (result nil))
-    (while (and (not (string= dir "/"))
+    (while (and (not (string= dir root))
                (not result))
        ((setq result (assoc dir project-directory-alist))

I don't think this is sufficient for the case when the current directory is say "C:/some_dir/" and file is "D:/file.txt"

Should this new project code be enabled by default? It seems to add a lot of directory searching overhead for simple file visiting, especially in batch mode.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]