Re: Yanking isearch to highlight-regexp

[David Koppelman]

I like the idea of combining regexp histories, but we might want to be
careful. I can see sharing patterns between hi-lock and occur because
they are used for locating things, but isearch patterns are used for
navigation and so might contain many regexps matching little pieces of
text that only occasionally would make good highlight targets.

I'd suggest having a shared history for occur and hi-lock with a few
recent isearch targets mixed in.



Juri Linkov <address@hidden> writes:

> As for the separate case of running `highlight-regexp' after isearch is
> finished, I suggest using the same default values as already provided by
> `occur-read-primary-args' and `keep-lines-read-args' that collect a list
> of useful regexps from different places including the last isearch string
> and put them to the list of default values.
>
> This also suggests to get rid of `hi-lock-regexp-history' in favor of
> the single regexp history variable `regexp-history' shared among all
> regexp-reading commands (perhaps `keep-lines-read-args' should be
> renamed to more general name like `read-regexp').
>