[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fixing non-NS darwin

From: Dan Nicolaescu
Subject: Re: fixing non-NS darwin
Date: Sun, 03 Aug 2008 21:02:29 -0700

YAMAMOTO Mitsuharu <address@hidden> writes:

  > >>>>> On Sun, 03 Aug 2008 19:26:24 -0700, Dan Nicolaescu <address@hidden> 
  > >> It's quite a common way in the Emacs code to comment out with #if 0
  > >> with leaving some explanation about why it is disabled.  Especially
  > >> for the case that people might make the same mistake again in
  > >> future unconsciously if that part were completely removed.
  > > So? Everyone is aware of that.  But that was absolutely not the case
  > > in this particular instance.  The comments and code did not make the
  > > intention clear for the casual reader.
  > Would casual readers care about admin/CPP-DEFINES?  

Of course, that is why it exists.

  > > If you actually want to contribute something positive, please add
  > > the missing documentation and fix the code.
  > It's not just a local problem.  I'm concerned about possible removals
  > of other important comments in your past/future cleanups.  It's really
  > inefficient if every developer has to check the excessive removal of
  > comments in (inherently optional) cleanups.

As usual you are making a mountain out of a molehill and making a
racket _again_ from nothing.  
Sorry, this is beyond silly.  So again: QUIT WAISTING MY TIME!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]