[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fixing non-NS darwin
From: |
Dan Nicolaescu |
Subject: |
Re: fixing non-NS darwin |
Date: |
Mon, 04 Aug 2008 10:31:58 -0700 |
Adrian Robert <address@hidden> writes:
> I've also gone through the removal diff and wanted to ask about the
> bit below since it may be something that all terms should do:
>
> Index: atimer.c
> ===================================================================
> RCS file: /sources/emacs/emacs/src/atimer.c,v
> retrieving revision 1.28
> retrieving revision 1.27
> diff -u -r1.28 -r1.27
> --- atimer.c 27 Jul 2008 18:24:40 -0000 1.28
> +++ atimer.c 14 May 2008 07:49:08 -0000 1.27
> @@ -368,7 +368,9 @@
>
> t = atimers;
> atimers = atimers->next;
> +#ifndef MAC_OSX
> t->fn (t);
> +#endif
>
> if (t->type == ATIMER_CONTINUOUS)
> {
> @@ -380,6 +382,10 @@
> t->next = free_atimers;
> free_atimers = t;
> }
> +#ifdef MAC_OSX
> + /* Fix for Ctrl-G. Perhaps this should apply to all
> platforms. */
> + t->fn (t);
> +#endif
>
> EMACS_GET_TIME (now);
> }
Is there evidence that this fixes a bug? Otherwise it would be very
likely against the feature freeze rules to check in something like
this.
- Re: fixing non-NS darwin (was: Re: your emacs/src/keyboard.h change), (continued)
- Re: fixing non-NS darwin (was: Re: your emacs/src/keyboard.h change), YAMAMOTO Mitsuharu, 2008/08/03
- Re: fixing non-NS darwin, Dan Nicolaescu, 2008/08/03
- Re: fixing non-NS darwin, YAMAMOTO Mitsuharu, 2008/08/03
- Re: fixing non-NS darwin, Dan Nicolaescu, 2008/08/03
- Re: fixing non-NS darwin, YAMAMOTO Mitsuharu, 2008/08/03
- Re: fixing non-NS darwin, Dan Nicolaescu, 2008/08/04
- Re: fixing non-NS darwin, Thien-Thi Nguyen, 2008/08/04
- Re: fixing non-NS darwin, Dan Nicolaescu, 2008/08/04
Re: fixing non-NS darwin, Dan Nicolaescu, 2008/08/03
Re: fixing non-NS darwin (was: Re: your emacs/src/keyboard.h change), Adrian Robert, 2008/08/04
Re: fixing non-NS darwin (was: Re: your emacs/src/keyboard.h change), Adrian Robert, 2008/08/04