Re: [PATCH] adding maximize to fullscreen frame parameters

[Eli Zaretskii]

> From: Ivan Kanis <address@hidden>
> Date: Sat, 23 Aug 2008 10:03:14 +0200
> 
> This patch against CVS HEAD is based on Tom's proposition. Sorry if
> it's repost, I am not sure the fist made it made it to the
> newsgroup. I will gladly write the changelog if someone plans to
> commit it.

Thanks.  Allow me a few comments on the documentation pieces:

> +size of the screen.  The value @code{maximize} specifies that both the
> +width and the height shall be set to the size of the screen. The value
> address@hidden toggles fullscreen mode, all windows decoration are hidden
> +such as title bar and border. The desktop taskbar is also hidden so it
> +looks like emacs is running on a console.

Please leave two spaces after a period that ends a sentence.

Also, I don't think "fullscreen" is a word (in "fullscreen mode"); I
suggest to use "full-screen" in this context.

> +  /* Maximise in X is full height plus full width */
> +  if (f->want_fullscreen == FULLSCREEN_MAXIMIZE)
> +    {
> +      f->want_fullscreen = FULLSCREEN_HEIGHT;
> +      XTfullscreen_hook(f);
> +      f->want_fullscreen = FULLSCREEN_WIDTH;
> +      XTfullscreen_hook(f);
> +    }
> +  else if (f->async_visible)

Why are you call XTfullscreen_hook twice here?