emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: VC commit missing ChangeLog message


From: Ted Zlatanov
Subject: Re: VC commit missing ChangeLog message
Date: Wed, 12 Nov 2008 11:17:31 -0600
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.60 (gnu/linux)

On Tue, 11 Nov 2008 17:11:06 -0800 (PST) Dan Nicolaescu <address@hidden> wrote: 

DN> If you are interested in improving this area, please also look at one of
DN> the TODO items in vc.el:

DN> ;; - When vc-next-action calls vc-checkin it could pre-fill the
DN> ;;   *VC-log* buffer with some obvious items: the list of files that
DN> ;;   were added, the list of files that were removed.  If the diff is
DN> ;;   available, maybe it could even call something like
DN> ;;   `diff-add-change-log-entries-other-window' to create a detailed
DN> ;;   skeleton for the log...
DN> ;;

I think that should be up to the user, to be done in the hook.  The
information, diff and files added/removed/affected, exists outside the
commit message so putting it inside the message duplicates the
information.

DN> If you are going to add the ChangeLog entries by default, then why
DN> bother with adding the text ?

DN> IMO adding text is inconvenient to users: they either have to read
DN> it, or they might think they have to delete it so that it does not
DN> get checked in.  It would be nice to be able to insert text that is
DN> not part of the buffer, like in the header line, but that is a
DN> single line unfortunately :-(

I see your point and agree.  How about this patch to just call
log-edit-insert-changelog?  I call it regardless of the SETUP parameter,
but it could follow the erase-buffer call instead.

Ted

Index: log-edit.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/log-edit.el,v
retrieving revision 1.51
diff -c -r1.51 log-edit.el
*** log-edit.el 6 May 2008 07:57:42 -0000       1.51
--- log-edit.el 12 Nov 2008 17:13:04 -0000
***************
*** 345,350 ****
--- 345,351 ----
  
      (if buffer (set (make-local-variable 'log-edit-parent-buffer) parent))
      (set (make-local-variable 'log-edit-initial-files) (log-edit-files))
+     (log-edit-insert-changelog)
      (when setup (run-hooks 'log-edit-hook))
      (goto-char (point-min)) (push-mark (point-max))
      (message "%s" (substitute-command-keys





reply via email to

[Prev in Thread] Current Thread [Next in Thread]