[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Lazy Isearch in dired

From: Chong Yidong
Subject: Re: Lazy Isearch in dired
Date: Thu, 13 Nov 2008 10:30:08 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

Juri Linkov <address@hidden> writes:

> There is a bug in Isearch in dired.  When Isearch is narrowed to only
> file names, Lazy Isearch highlights matches outside of the Isearch scope.
> This is very confusing since C-s and C-r will never visit them.
> The following patch fixes this by using a loop like the loop in the
> function `isearch-search'.  The docstring of isearch-lazy-highlight-search
> says: "Attempt to do the search exactly the way the pending isearch would.",
> so no changes in the docstring are needed, because this patch makes it
> more similar to the main search function.  It also calls 
> isearch-success-function
> to skip the matches outside the current Isearch scope.  By default this
> function skips invisible matches that are useless for lazy highlighting.
> This also requires setting search-invisible to nil to not match
> invisible text.

Hmm, your patch looks reasonable, but I'm not sure.  Could it possibly
lead to slowdowns in some buffers from the additional search loop?
Maybe we should hold this till after the release.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]