[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Reviewing changes

From: Stefan Monnier
Subject: Re: Reviewing changes
Date: Fri, 21 Nov 2008 09:32:28 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

>> So you object to naming them "code reviews"?  That's OK, let's call them
>> "random comments", then.
>> I just can't see how encouraging such random comments can hurt.

> I didn't say it will hurt.  I said it won't help us make the code
> quality better, which I assumed what this was all about.  Sounds like
> my assumption was wrong.

No, this was all about asking to change the format of the email sent to
emacs-diffs and emacs-commit so that they'd contain both the changelog
and the diffs (hopefully of all the files modified by the given
commit) together.
Karl mentioned he'd prefer it, and also added that it would make
reviewing easier.

Your argumentation seemed to say that you disagreed with such a change
specifically because it would make people start to do such
pseudo-reviewing which is worse than not doing reviewing at all.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]