Re: [Emacs-diffs] emacs/lisp ChangeLog bookmark.el

[Karl Fogel]

Stefan Monnier <address@hidden> writes:
> Modified files:
>       lisp           : ChangeLog bookmark.el 
>
> Log message:
>       (bookmark-get-bookmark): Add `noerror' arg.
>       Signal error for invalid bookmark.
>       (bookmark-get-bookmark-record): Undo last change.
>       (bookmark-store, bookmark-delete): Use new arg `noerror'.

Thanks for doing this.  Minor comment below:

> Index: bookmark.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/bookmark.el,v
> retrieving revision 1.121
> retrieving revision 1.122
> diff -u -b -r1.121 -r1.122
> --- bookmark.el       21 Nov 2008 19:07:24 -0000      1.121
> +++ bookmark.el       21 Nov 2008 19:29:19 -0000      1.122
> @@ -79,6 +79,7 @@
>  ;;; Code:
>  
>  (require 'pp)
> +(eval-when-compile (require 'cl))

What's this part of the change for?  (It's not mentioned in the log
message, but independently of that, I couldn't tell its purpose.)

The rest looked good to me.

-Karl