emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bug in server-start


From: Juanma Barranquero
Subject: Re: bug in server-start
Date: Tue, 16 Dec 2008 13:15:54 +0100

On Tue, Dec 16, 2008 at 12:49, Ulrich Mueller <address@hidden> wrote:

> Looks good, except for the exit status of the parent which is zero.
> The following will test for one character to be read from the pipe
> (which is sent when daemon-initialized is called):
>
> --- src/emacs.c
> +++ src/emacs.c
> @@ -1124,7 +1124,7 @@
>            }
>          while (retval == -1 && errno == EINTR);
>
> -         if (retval < 0)
> +         if (retval <= 0)
>            {
>              fprintf (stderr, "Error reading status from child\n");
>              exit (1);
>

I cannot test that part of the code, so I'll leave that change for Dan.

As for my changes, have you tested them? ("Looks good" is not the same
as "Works OK" ;-)

    Juanma




reply via email to

[Prev in Thread] Current Thread [Next in Thread]