[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Changes 2009-07-15/16 in branch?

From: Adrian Robert
Subject: Changes 2009-07-15/16 in branch?
Date: Thu, 23 Jul 2009 07:22:55 -0400

Hello Yamamoto-san,

Did you mean to check the changes below into the branch? I *think* these are pretty safe, but it seems a bit close to release for such feature changes, even in the name of standardization. My vote would be to do these on trunk only for now.


ns_get_color(): Shouldn't the description comment for ns_get_color() be updated further? It looks like something was just chopped off, leaving the rest making little sense. What is the bug or problem this change fixes?

ns_color_to_lisp(): The function could be simplified now that you have eliminated a special case.

nsfont_draw(): Would setting the foreground instead of the background color to the bitmap constitute a corrected implementation?

ns-set-background-alpha: The implementation you just removed was superior to that for (set-frame-parameter nil 'alpha ##): it does not alter the alpha of the titlebar, scrollbars, modeline, or text. This makes it usable, instead of a curiosity. It also provides access via an interactive function. The correct fix would be to improve the (set- frame-parameter) version, not remove this while no alternative exists for users.

2009-07-16  YAMAMOTO Mitsuharu  <address@hidden>

        * nsfns.m (Fns_set_alpha): Remove function.
        (syms_of_nsfns): Don't defsubr it.

        * nsterm.m (ns_get_color): Remove incompatible color formats.
        (ns_color_to_lisp): Generate #rrggbb color format string.

2009-07-15  YAMAMOTO Mitsuharu  <address@hidden>

* nsfont.m (nsfont_draw): Remove code for stippling, which actually
        does tiling.

        * nsterm.m (ns_maybe_dumpglyphs_background): Likewise.

2009-07-16  YAMAMOTO Mitsuharu  <address@hidden>

        * term/ns-win.el (ns-set-alpha): Don't declare.
        (ns-set-background-alpha): Remove function.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]