[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
hashtable-print-readable provide point (was: Build failure in current gi
From: |
Ted Zlatanov |
Subject: |
hashtable-print-readable provide point (was: Build failure in current git checkout) |
Date: |
Thu, 06 Aug 2009 07:04:57 -0500 |
User-agent: |
Gnus/5.110011 (No Gnus v0.11) Emacs/23.1.50 (darwin) |
On Wed, 05 Aug 2009 23:43:23 -0500 Manoj Srivastava <address@hidden> wrote:
MS> I am getting a build failure for the master branch from the git
MS> repository, summarized below (I can provide more details if needed)
On Thu, 06 Aug 2009 13:39:37 +0300 Teemu Likonen <address@hidden> wrote:
TL> I git-bisected it to this commit:
TL> commit 3cd069ec588527f4baac7a71d93ccc080668eebf
TL> Author: Teodor Zlatanov <address@hidden>
TL> Date: Wed Aug 5 09:19:21 2009 +0000
TL> * lread.c (read1, syms_of_lread): Read hashtables back from the
TL> readable format.
TL> * print.c (print_preprocess, print_object): Print hashtables fully
TL> and readably.
TL> (syms_of_print): Provide 'hashtable-print-readable.
On Thu, 6 Aug 2009 03:13:55 -0700 (PDT) Dan Nicolaescu <address@hidden> wrote:
DN> This patch breaks the build, temacs crashes on startup.
DN> You cannot call Fprovide in print.c, it's initialized later than that.
When I tested I didn't do a full build. I'll gladly move the call
Fprovide (intern ("hashtable-print-readable"), Qnil);
to wherever it belongs, but I don't see `provide' called in any other .c
files except for xfns.c (X functions), dbusbins.c, process.c, and
terminal.c. I don't think this `provide' call belongs in any of them.
I guess process.c is the closest one, but I'd rather not pollute it with
unrelated code.
I can put the `provide' call in the lisp/ tree but again, I don't know
where it should go there.
Ted
- Build failure in current git checkout, Manoj Srivastava, 2009/08/06
- Re: Build failure in current git checkout, Daniel Clemente, 2009/08/06
- Re: Build failure in current git checkout, Teemu Likonen, 2009/08/06
- hashtable-print-readable provide point (was: Build failure in current git checkout),
Ted Zlatanov <=
- Re: hashtable-print-readable provide point (was: Build failure in current git checkout), Andreas Schwab, 2009/08/06
- Re: hashtable-print-readable provide point, Ted Zlatanov, 2009/08/06
- Re: hashtable-print-readable provide point, Stefan Monnier, 2009/08/06
- Re: hashtable-print-readable provide point, Chong Yidong, 2009/08/08
- Re: hashtable-print-readable provide point, Stefan Monnier, 2009/08/08
- Re: hashtable-print-readable provide point, Ted Zlatanov, 2009/08/28