[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] emacs/lisp image.el
From: |
Juri Linkov |
Subject: |
Re: [Emacs-diffs] emacs/lisp image.el |
Date: |
Sun, 30 Aug 2009 01:46:23 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) |
>> Log message:
>> (image-type-header-regexps): Use only JPEG magic number
>> to determine JPEG images, and don't use `image-jpeg-p' because
>> Emacs can display non-JFIF non-Exif JPEG images.
>
> Then we should perhaps obsolete `image-jpeg-p' (which is not used
> anymore in the sources).
>
> Currently it does what its docstring says, but there's some of a
> mismatch with the name (which seems to imply more generality); also it
> is not clear what purpose does serve a function to detect just
> JFIF/Exif JPEGs. And generalizing it would turn it into a trivial
> two-liner.
I left `image-jpeg-p' in image.el for the case it's used by some
external packages or .emacs files since it contains a non-trivial
algorithm for detecting JFIF/Exif JPEGs. Even though its name is
not too specific, its docstring explains what it does.
--
Juri Linkov
http://www.jurta.org/emacs/