[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Cygwin patches

From: Eli Zaretskii
Subject: Re: Cygwin patches
Date: Sat, 21 Nov 2009 14:42:02 +0200

> Date: Sat, 21 Nov 2009 07:12:04 -0500
> From: Ken Brown <address@hidden>
> CC: address@hidden, address@hidden
> > I think that the right fix would be in browse-url-file-url, so that it
> > does return a correctly converted URL.  Using cygstart directly in
> > browse-url-of-file deviates too much from what other platforms do --
> > they all invoke the browser in browse-url.  Such a deviation could
> > mean maintenance headaches in the future.  For example, browse-url
> > takes care of setting the environment for the process being invoked,
> > while your patch short-circuits that for Cygwin.
> OK, that makes sense.  I'll figure out how to patch browse-url-file-url 
> instead.


> But it will still mean cygwin-specific code in that function. 
> Is that acceptable?

Yes, of course.

> [BTW, Lennart's suggestion that the cygwin-specific code should be moved 
> to browse-url doesn't work.  In fact, browse-url works fine on cygwin as 
> is; it just needs to be given a good URL.]

Right, I figured that much.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]