[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Cygwin patches

From: Ken Brown
Subject: Re: Cygwin patches
Date: Sun, 22 Nov 2009 07:59:56 -0500
User-agent: Thunderbird (Windows/20090605)

On 11/22/2009 12:25 AM, Davis Herring wrote:
+  (if (eq system-type 'cygwin)
+      (let ((winfile (shell-command-to-string (concat
+                         "cygpath -m " (shell-quote-argument file)))))
+       (setq file (concat "file://" (substring winfile 0 -1)))))

I would instead bind winfile to

  (call-process "cygpath" nil standard-output nil "-m" file))

(using, like `shell-command-to-string' does, the undocumented feature that
`with-output-to-string' causes `standard-output' to be a temporary
buffer).  Then you don't have to worry with `shell-quote-argument'.

Thanks for the suggestion. My revised patch is attached. If it looks OK, could someone please check it in?



Attachment: browse-url.el.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]