[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix info display of images

From: Juri Linkov
Subject: Re: Fix info display of images
Date: Sun, 13 Dec 2009 20:31:35 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.90 (x86_64-pc-linux-gnu)

> Since there does not appear to be interest to apply this patch, let me
> illustrate the difference using two screen shots, the first without the
> patch, the second with the patch.

Thanks, it's clear now what is the reason of this bug.

`Info-hide-cookies-node' hides a cookie, including one optional
*trailing newline*.

The image cookies in Lilypond's Cheat sheet end with trailing newlines,
so when `Info-hide-cookies-node' hides the newline, images are displayed
in one long line.

It seems hiding the newline was necessary only for index cookies,
that after hiding would leave an empty line.

OTOH, the docstring of `Info-hide-cookies-node' says:

  Hide unrecognized cookies in current node.

So your patch uses `(not (get-text-property start 'display))' to tell
`Info-hide-cookies-node' that this cookie was already recognized and
processed by `Info-display-images-node'.

> I think that the improvement is rather obvious.

This is not just improvement, but a plain bug fix.  I suggest to install it.

Since IIUC currently CVS is read-only, you could create a bug report in
the bug database to guarantee your bug fix is not lost and fixed in the
next release.

Juri Linkov

reply via email to

[Prev in Thread] Current Thread [Next in Thread]