[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: visible-bell patch for Mac OS X

From: YAMAMOTO Mitsuharu
Subject: Re: visible-bell patch for Mac OS X
Date: Sat, 13 Feb 2010 10:30:44 +0900
User-agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (Shijō) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI)

>>>>> On Tue, 02 Feb 2010 08:33:22 +0900, YAMAMOTO Mitsuharu <address@hidden> 
>>>>> said:

>> YAMAMOTO Mitsuharu <address@hidden> writes:
>>> The patch consists of ~80 lines.  Is it considered a "tiny
>>> change"?

>> I have started the copyright assignment process with Filipe.

> Besides that, I'd suggest reverting the patch for now for several
> reasons: it does not work on the second frame, it gives inconsistent
> flashed area when the scroll bars are placed on the left side, and
> it breaks GNUstep builds.

Bug#5569 confirms the last issue.  It also breaks build on Mac OS X
10.4 because of the lack of NSRectToCGRect.

BTW, I noticed that the GTK+ build may also flash part of scroll bars
if GDK_NATIVE_WINDOWS is not set.  One can argue that the current
behavior of Emacs 22 Carbon(+AppKit) port and Emacs 23 Mac port is
compatible with this :-p (though I'm planning to change this behavior
in the next releases of the Mac port).

                                     YAMAMOTO Mitsuharu

reply via email to

[Prev in Thread] Current Thread [Next in Thread]