[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Emacs 23.1.93 pretest

From: Chong Yidong
Subject: Re: Emacs 23.1.93 pretest
Date: Sat, 27 Feb 2010 16:37:47 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.93 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

> "bzr bisect" points to this change as the reason for this bug:
>     2010-02-05  Chong Yidong  <address@hidden>
>           * charset.c (load_charset_map_from_file): Allocate large
>           charset_map_entries structure on the heap rather than the stack.
>           (Bug#5526).
> The revisions before this change works correctly; all revisions after
> it fail as described above.

Hmm, this is strange.  This change (actually the succeeding 2010-02-06
change to the same place) switches from using alloca to SAFE_ALLOCA
(i.e. malloc, since the desired structure is large).  But the only way I
can see for this code to crash is if load_charset_map somehow makes a
pointer into the allocated structure.  But in that case, the old alloca
case should have crashed too.

If you remove the SAFE_FREE () calls, does that prevent the crash?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]