[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Concerning the new `ido-use-virtual-buffers' feature
From: |
Leo |
Subject: |
Re: Concerning the new `ido-use-virtual-buffers' feature |
Date: |
Fri, 28 May 2010 10:07:47 +0100 |
> > Also remember to try the toggle virtual buffers key C-o too. Thanks.
>
> What do you mean with this one?
The C-o key when switching buffers toggles virtual buffers on and off
so it it good make sure it is still working after the patch.
>> The can be changed
>> @@ -3427,7 +3431,9 @@ for first matching file."
>> (if default
>> (setq ido-temp-list
>> (cons default (delete default ido-temp-list))))
>> - (if ido-use-virtual-buffers
>> + (if (or (eq ido-use-virtual-buffers 'always)
>> + (and (boundp ido-virtual-buffers-enabled)
>> + ido-virtual-buffers-enabled))
>> (ido-add-virtual-buffers-to-list))
>> (run-hooks 'ido-make-buffer-list-hook)
>> ido-temp-list))
>>
>>
>> to:
>>
>> @@ -2736,7 +2739,8 @@ C-x C-f ... C-d enter `dired' on current directory."
>> See `ido-use-virtual-buffers' for explanation of virtual buffer."
>> (interactive)
>> (when (and ido-mode (eq ido-cur-item 'buffer))
>> - (setq ido-use-virtual-buffers (not ido-use-virtual-buffers))
>> + (setq ido-virtual-buffers-enabled
>> + (not ido-virtual-buffers-enabled))
>> (setq ido-text-init ido-text)
>> (setq ido-exit 'refresh)
>> (exit-minibuffer)))
I copied the wrong text. Never mind. I have just recreated the patch
against current trunk.
The only bit that I am unsure is the deleted lines in the following
hunk. i.e. if method is 'kill disregard virtual buffers. Seems like
someone wants to work around a bug. But I don't know what it is so I
didn't implement a similar logic in the added lines.
Again my testing is very brief so it can break things.
@@ -2181,9 +2191,8 @@ If cursor is not at the end of the user input,
move to end of input."
(ido-current-directory nil)
(ido-directory-nonreadable nil)
(ido-directory-too-big nil)
- (ido-use-virtual-buffers (if (eq method 'kill)
- nil ;; Don't consider virtual
buffers for killing
- ido-use-virtual-buffers))
+ (ido-virtual-buffers-enabled (eq ido-use-virtual-buffers 'always))
+ (ido-virtual-buffers-inhibit (not ido-virtual-buffers-enabled))
(require-match (confirm-nonexistent-file-or-buffer))
(buf (ido-read-internal 'buffer (or prompt "Buffer: ")
'ido-buffer-history default
require-match initial))
@@ -2224,7 +2233,8 @@ If cursor is not at the end of the user input,
move to end of input."
Best,
Leo
ido-vbuffers.diff
Description: Binary data
- Re: Concerning the new `ido-use-virtual-buffers' feature, (continued)
Re: Concerning the new `ido-use-virtual-buffers' feature, Leo, 2010/05/27
- Re: Concerning the new `ido-use-virtual-buffers' feature, Tassilo Horn, 2010/05/27
- Re: Concerning the new `ido-use-virtual-buffers' feature, Leo, 2010/05/27
- Re: Concerning the new `ido-use-virtual-buffers' feature, Tassilo Horn, 2010/05/27
- Re: Concerning the new `ido-use-virtual-buffers' feature, Leo, 2010/05/27
- Re: Concerning the new `ido-use-virtual-buffers' feature, Leo, 2010/05/27
- Re: Concerning the new `ido-use-virtual-buffers' feature, Tassilo Horn, 2010/05/28
- Re: Concerning the new `ido-use-virtual-buffers' feature,
Leo <=
- Re: Concerning the new `ido-use-virtual-buffers' feature, Leo, 2010/05/28
- Re: Concerning the new `ido-use-virtual-buffers' feature, Juanma Barranquero, 2010/05/28
- Re: Concerning the new `ido-use-virtual-buffers' feature, Leo, 2010/05/28
- Re: Concerning the new `ido-use-virtual-buffers' feature, Tassilo Horn, 2010/05/28
- Re: Concerning the new `ido-use-virtual-buffers' feature, Leo, 2010/05/29