[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] Passes notification id as argument of on-action and on-close fun
From: |
Julien Danjou |
Subject: |
[PATCH] Passes notification id as argument of on-action and on-close functions |
Date: |
Thu, 10 Jun 2010 10:43:04 +0200 |
Signed-off-by: Julien Danjou <address@hidden>
---
lisp/ChangeLog | 6 ++++++
lisp/net/notifications.el | 16 +++++++++++-----
2 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index a21517b..07a36ce 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,9 @@
+2010-06-10 Julien Danjou <address@hidden>
+
+ * net/notifications.el (notifications-on-action-signal)
+ (notifications-on-closed-signal): Pass notification id as first
+ argument to the callback functions. Add docstrings.
+
2010-06-10 Glenn Morris <address@hidden>
* emacs-lisp/authors.el (authors-ignored-files)
diff --git a/lisp/net/notifications.el b/lisp/net/notifications.el
index ef246c7..4b619a4 100644
--- a/lisp/net/notifications.el
+++ b/lisp/net/notifications.el
@@ -86,9 +86,11 @@
"Mapping between notification and close callback functions.")
(defun notifications-on-action-signal (id action)
+ "Dispatch notifications action signals to callback functions
+from `notifications-on-action-map'."
(let ((entry (assoc id notifications-on-action-map)))
(when entry
- (funcall (cadr entry) action)
+ (funcall (cadr entry) id action)
(remove entry 'notifications-on-action-map))))
(dbus-register-signal
@@ -100,9 +102,11 @@
'notifications-on-action-signal)
(defun notifications-on-closed-signal (id reason)
+ "Dispatch closed notification signals to callback functions
+from `notifications-on-closed-map'."
(let ((entry (assoc id notifications-on-close-map)))
(when entry
- (funcall (cadr entry) (cadr (assoc reason notifications-closed-reason)))
+ (funcall (cadr entry) id (cadr (assoc reason
notifications-closed-reason)))
(remove entry 'notifications-on-close-map))))
(dbus-register-signal
@@ -155,11 +159,13 @@ Various PARAMS can be set:
should point to. The \"y\" hint must also be specified.
:y Specifies the Y location on the screen that the notification
should point to. The \"x\" hint must also be specified.
- :on-action Function to call when an action is invoked. The key of the
- action is passed as argument to the function.
+ :on-action Function to call when an action is invoked.
+ The notification id and the key of the action are passed
+ as arguments to the function.
:on-close Function to call when the notification has been closed
by timeout or by the user.
- The function receives the closing reason as argument:
+ The function receive the notification id and the closing
+ reason as arguments:
- `expired' if the notification has expired
- `dismissed' if the notification was dismissed by the user
- `close-notification' if the notification was closed
--
1.7.1
- Re: [PATCH] Add notifications.el, (continued)
- Re: [PATCH] Add notifications.el, Julien Danjou, 2010/06/09
- Re: [PATCH] Add notifications.el, Tassilo Horn, 2010/06/09
- Re: [PATCH] Add notifications.el, Julien Danjou, 2010/06/09
- Re: [PATCH] Add notifications.el, Tassilo Horn, 2010/06/09
- Re: [PATCH] Add notifications.el, Stefan Monnier, 2010/06/09
- Re: [PATCH] Add notifications.el, Julien Danjou, 2010/06/09
- Re: [PATCH] Add notifications.el, Stefan Monnier, 2010/06/09
- Re: [PATCH] Add notifications.el, Tassilo Horn, 2010/06/10
- Re: [PATCH] Add notifications.el, Julien Danjou, 2010/06/10
- Re: [PATCH] Add notifications.el, Michael Albinus, 2010/06/10
- [PATCH] Passes notification id as argument of on-action and on-close functions,
Julien Danjou <=
- Re: [PATCH] Passes notification id as argument of on-action and on-close functions, Michael Albinus, 2010/06/10
- Re: [PATCH] Passes notification id as argument of on-action and on-close functions, Julien Danjou, 2010/06/10
- Re: [PATCH] Passes notification id as argument of on-action and on-close functions, Michael Albinus, 2010/06/10
- Re: [PATCH] Passes notification id as argument of on-action and on-close functions, Juri Linkov, 2010/06/10
- Re: [PATCH] Passes notification id as argument of on-action and on-close functions, Michael Albinus, 2010/06/10
- Re: [PATCH] Passes notification id as argument of on-action and on-close functions, Juri Linkov, 2010/06/10
- Re: [PATCH] Passes notification id as argument of on-action and on-close functions, Michael Albinus, 2010/06/10
- Re: [PATCH] Passes notification id as argument of on-action and on-close functions, Stefan Monnier, 2010/06/10
- Re: [PATCH] Passes notification id as argument of on-action and on-close functions, Juri Linkov, 2010/06/10
- Re: [PATCH] Passes notification id as argument of on-action and on-close functions, Stefan Monnier, 2010/06/10