[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: split up process.c

From: Chong Yidong
Subject: Re: split up process.c
Date: Sun, 11 Jul 2010 10:48:39 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

>> > There's now only one function, wait_reading_process_output, which
>> > has 2 different implementations.  (I could easily have a single
>> > function with two different bodies conditioned by `subprocesses',
>> > or I could move the second implementation to msdos.c, if people
>> > prefer that.  But both alternatives looked no cleaner, and the
>> > latter would even make more maintenance headaches, IMO.)
>> IMO it should go to msdos.c unless that requires other important code
>> changes.
> I will defer to Stefan and Yidong for the decision.  Personally, I
> think having a function with the same name on two different source
> files will make maintenance a tad harder than it is when they are on
> the same file.

I think the present situation is fine.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]