emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Improving Emacs performance on Cygwin


From: Ken Brown
Subject: Improving Emacs performance on Cygwin
Date: Mon, 26 Jul 2010 17:00:06 -0400
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.4) Gecko/20100608 Thunderbird/3.1

I would like to apply the following patch, which seems to give a substantial performance improvement on Cygwin (and obviously has no effect on other platforms).

=== modified file 'src/dired.c'
--- src/dired.c 2010-07-25 00:20:51 +0000
+++ src/dired.c 2010-07-26 20:49:34 +0000
@@ -72,8 +72,7 @@
 #endif /* not MSDOS */
 #endif /* not SYSV_SYSTEM_DIR */

-/* Some versions of Cygwin don't have d_ino in `struct dirent'.  */
-#if defined(MSDOS) || defined(__CYGWIN__)
+#ifdef MSDOS
 #define DIRENTRY_NONEMPTY(p) ((p)->d_name[0] != 0)
 #else
 #define DIRENTRY_NONEMPTY(p) ((p)->d_ino)

This reverses a change made by Eli on 2006-01-27. Rationale: The time when Cygwin didn't have d_ino in dirent was a brief period around December 2005, and it applied only to Cygwin 1.5.19, which has long been obsolete.

Any objections? If not, I would apply it to the emacs-23 branch and let it propagate to the trunk.

Ken



reply via email to

[Prev in Thread] Current Thread [Next in Thread]