[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: rename and clean unexec.c

From: Dan Nicolaescu
Subject: Re: rename and clean unexec.c
Date: Wed, 28 Jul 2010 23:21:40 -0400
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

>> From: Dan Nicolaescu <address@hidden>
>> Date: Wed, 28 Jul 2010 18:55:45 -0400
>> Cc: Óscar Fuentes <address@hidden>, address@hidden
>> Eli Zaretskii <address@hidden> writes:
>> >> From: Óscar Fuentes <address@hidden>
>> >> Date: Wed, 28 Jul 2010 22:13:16 +0200
>> >> 
>> >> Speaking as someone who is getting familiar with the code base, it is
>> >> useful to see a hint on the name about its platform-specific nature.
>> >
>> > unexec.c is not DOS-specific.  It is for any platform that uses COFF.
>> > It just so happens that MSDOS is the only one that still does.
>> Then let's call it unexcoff.c then so that it follows some kind of
>> rule like all the other unexec files.  It's not very logical to refuse
>> to change the least used one.
> Why is it so important to rename this file?  I'm not against renaming

For long term maintainability.
Good, suggestive file names are good for maintainability.

When we have a rule and a single file does not follow it, it not good.
We finally have the right support for renaming so there's not reason
to keep a very old name that's not accurate anymore and it's the wrong
place to look for the "unexec" function for close to (100% -1person)
of the developers.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]