[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: HAVE_SOCKETS in w32*

From: Jason Rumney
Subject: Re: HAVE_SOCKETS in w32*
Date: Wed, 15 Sep 2010 13:21:00 +0800
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20100111 Thunderbird/3.0.1

On 15/09/2010 09:46, Juanma Barranquero wrote:
On Thu, Aug 5, 2010 at 20:05, Dan Nicolaescu<address@hidden>  wrote:

HAVE_SOCKETS is defined unconditionally in s/ms-w32.h, yet some w32*.c
files use HAVE_SOCKETS #ifdefs.

It would be good to get rid of those.
The following patch does that; it also removes the few uses of
SOCK_REPLACE_HANDLE, which has been commented out since 1996.

Eli, Jason?

Its OK to remove this. HAVE_SOCKETS was needed for the original release of Windows 95, as sockets were an optional component that was not always installed. Later versions (including a later update of Windows 95) always install with networking support. SOCK_REPLACE_HANDLE looks like it was experimental code from when sockets were first implemented.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]