[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/1] compile.el bug in recognizing -o switches among output
From: |
Jes Bodi Klinke |
Subject: |
Re: [PATCH 1/1] compile.el bug in recognizing -o switches among output |
Date: |
Wed, 27 Oct 2010 14:37:09 -0700 (PDT) |
User-agent: |
SquirrelMail/1.4.15 |
This is embarassing. Apparently I was overconfident in my ability to make
some final simplifications of the regex, without needing to retest it. I
accidentally messed up the subexpression numbering in my previous patch
(by adding an outer pair of parentheses). The correct regex is:
" -\\(?:o[= ]?\\|-\\(?:outfile\\|output\\)[= ]\\)\\(\\S +\\)"
Please use this patch instead of my previous one. I am very sorry for the
inconvenience, I hope that I will be able to provide better contributions
in the future.
Regards
Jes Bodi Klinke
=== modified file 'lisp/progmodes/compile.el'
*** lisp/progmodes/compile.el 2010-09-24 03:06:33 +0000
--- lisp/progmodes/compile.el 2010-10-27 21:30:57 +0000
*** 543,549 ****
;; Command output lines. Recognize `make[n]:' lines too.
("^\\([[:alnum:]_/.+-]+\\)\\(\\[\\([0-9]+\\)\\]\\)?[ \t]*:"
(1 font-lock-function-name-face) (3 compilation-line-face nil t))
! (" --?o\\(?:utfile\\|utput\\)?[= ]?\\(\\S +\\)" . 1)
("^Compilation \\(finished\\).*"
(0 '(face nil message nil help-echo nil mouse-face nil) t)
(1 compilation-info-face))
--- 543,549 ----
;; Command output lines. Recognize `make[n]:' lines too.
("^\\([[:alnum:]_/.+-]+\\)\\(\\[\\([0-9]+\\)\\]\\)?[ \t]*:"
(1 font-lock-function-name-face) (3 compilation-line-face nil t))
! (" -\\(?:o[= ]?\\|-\\(?:outfile\\|output\\)[= ]\\)\\(\\S +\\)" . 1)
("^Compilation \\(finished\\).*"
(0 '(face nil message nil help-echo nil mouse-face nil) t)
(1 compilation-info-face))