emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/1] compile.el bug in recognizing -o switches among


From: Jes Bodi Klinke
Subject: Re: [PATCH 1/1] compile.el bug in recognizing -o switches among
Date: Thu, 28 Oct 2010 12:43:26 -0700 (PDT)
User-agent: SquirrelMail/1.4.15

>> (by adding an outer pair of parentheses).  The correct regex is:
>> " -\\(?:o[= ]?\\|-\\(?:outfile\\|output\\)[= ]\\)\\(\\S +\\)"
>
> Thanks, installed.
> But, could you tell me how you made your patches?
> Neither diff-mode nor `patch' understand their format:

Thank you.  Responses like this to my feedback encourages me to spend more
time on Emacs the next time.

About the patch.  I manually edited the output from bzr diff.  I deleted
what I thought was a comment line.  It looked like bzr had tried to
extract the name of the enclosing function, but it had failed badly and
pulled out part of an unrelated text literal.  I thought that letting it
be could confuse human readers of the patch, but I guess I should have
just deleted the text to the right of the ***********, not the entire
line.

Regards
Jes Bodi Klinke




reply via email to

[Prev in Thread] Current Thread [Next in Thread]