[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch for fields of `struct buffer'

From: Stefan Monnier
Subject: Re: Patch for fields of `struct buffer'
Date: Fri, 28 Jan 2011 09:55:56 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

> Here is the promised change to buffer fields.

Please make the "#define BUF_FOO(BUF) ((BUF)->foo_)" to be
auto-generated (they could go into global.h).
Oh and the arg shojuld be `buf' rather than `BUF'.

I'd also be happier if the buffer.h code that defines the fields used
names without _ (so they'd have to be passed to a macro that adds the _).
Similarly the alloc.c code should ideally not hard-code the "add an _"
at every use but instead use some kind of macro call like
BUFFER_INTERNAL_FIELD(foo) that would return "foo_".


reply via email to

[Prev in Thread] Current Thread [Next in Thread]