[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bug in copy-directory
From: |
Michael Albinus |
Subject: |
Re: bug in copy-directory |
Date: |
Tue, 01 Feb 2011 10:44:21 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
Chong Yidong <address@hidden> writes:
> Michael Albinus <address@hidden> writes:
>
>> Your patch breaks recursive copy now. Extend the use case from that bug
>> report:
>>
>> - Create directory /tmp/test
>> - Create directory /tmp/test/test
>> - Create file /tmp/test/a
>> - Create file /tmp/test/test/b
>>
>> - Apply (copy-directory "/tmp/test" "~/")
>> Everything is fine
>>
>> - Apply again (copy-directory "/tmp/test" "~/")
>> The target directory structure is broken.
>
> I think I see the problem: the arguments to the recursive call to
> copy-directory were not taking the "copy as a subdirectory" behavior
> into account. I've committed a fix.
It works fine, thank you. But there seems to be a bug in dired; when I
copy "/tmp/test" to "~/" twice, I see the corrupted directory structure.
(This seems to be the misunderstanding between Thierry and me, 'cause I
have used dired for my tests).
I've tested also
(copy-directory "/ssh::/tmp/test" "/ssh::~/")
(copy-directory "/rsync::/tmp/test" "/rsync::~/")
In the ssh case, Tramp falls back to the default implementation. For
rsync, there is an own implementation. Both tests are successful; Tramp
seems to be OK.
Best regards, Michael.
- Re: bug in copy-directory,
Michael Albinus <=
- Re: bug in copy-directory, Thierry Volpiatto, 2011/02/01
- Re: bug in copy-directory, Thierry Volpiatto, 2011/02/02
- Re: bug in copy-directory, Michael Albinus, 2011/02/02
- Re: bug in copy-directory, Thierry Volpiatto, 2011/02/02
- Re: bug in copy-directory, Thierry Volpiatto, 2011/02/04
- Re: bug in copy-directory, Michael Albinus, 2011/02/04
- Re: bug in copy-directory, Thierry Volpiatto, 2011/02/04
- Re: bug in copy-directory, Michael Albinus, 2011/02/04
- Re: bug in copy-directory, Thierry Volpiatto, 2011/02/04
- Re: bug in copy-directory, Chong Yidong, 2011/02/06