[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r103075: * lisp/simple.el (specia

From: Stefan Monnier
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r103075: * lisp/simple.el (special-mode-map): Bind "h" to `describe-mode';
Date: Sat, 05 Feb 2011 14:24:57 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

> -(defvar bookmark-bmenu-mode-map
> -  (let ((map (make-keymap)))
> +(define-key bookmark-bmenu-mode-map "q" 'quit-window)
> +(define-key bookmark-bmenu-mode-map "v" 'bookmark-bmenu-select)

This change, along with other similar ones you made in the above commit
is wrong.  Keymaps need to be defined within their `defvar'.
The use of define-derived-mode makes no difference to it.

You'll see various "move initialization into declaration" messages in
the ChangeLog showing that we have been working to move things into the
defvars rather than out of it.

Can you please fix those changes (don't just revert it, of course: the
use special-mode is right, but leave the various "defvar foo-mode-map"
and keep the define-key calls within those defvars)?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]