[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bug in copy-directory

From: Chong Yidong
Subject: Re: bug in copy-directory
Date: Sat, 12 Feb 2011 17:46:17 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

Thierry Volpiatto <address@hidden> writes:

>> 1. I didn't apply the change to dired-aux.el.  It doesn't seem to do the
>> right thing.  With that change patch, if I try to use the `C' command in
>> Dired, I get an error.
>>    mkdir ~/a
>>    emacs ~/
>>    [move point to a]
>>    C
>>    ~/b RET  => error.
> To be sure:
> b is a non--existing directory, right?


>> 2. You have non-standard indentation settings which make your patches
>> bigger than they should be, harder to read, and requires re-editing of
>> the results before they can be committed.  Stuff like this should not be
> I use cl indent, just apply patch and reindent.

It's unreasonable to ask others to apply a patch, edit the results, and
rediff just to read your patches.  It defeats the purpose of diffs.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]