[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Unconditional quit on SIGUSR2
From: |
Daniel Colascione |
Subject: |
Re: [PATCH] Unconditional quit on SIGUSR2 |
Date: |
Mon, 25 Apr 2011 11:21:35 -0700 |
User-agent: |
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9 |
On 4/25/11 6:32 AM, Stefan Monnier wrote:
> That reminds me of the idea to turn C-g C-g C-g into a "really break, no
> matter what" key sequence. Someone posted a patch for it a while back
> and I didn't find the time to review it back then.
That's okay as it's optional. I don't want to kill
fontification because I lean on C-g.
> I'm not sure I'd want to advertise this feature in all manuals at this
> point. I'd rather see it in etc/DEBUG.
Fair enough.
> And it should include some info
> about what happens after you get the backtrace: e.g. can you just hit
> `q' to abort the inf-loop and go on using this Emacs sessions as if
> nothing happened?
Yes, and I'll add that.
>> + if (SYMBOLP (Vdebug_on_special_event) &&
>> + STRINGP (XSYMBOL (Vdebug_on_special_event)->xname))
>
> Use SYMBOL_NAME. And I don't think STRINGP is needed here.
Will do.
> Another minor problem is that you use a name with "special-event" and
> the doc makes references to "special-event-map" yet the two are
> fundamentally unrelated (except that they both can handle SIGUSRn
> signals).
The idea is that the event named by the variable is in the same
namespace as the events in special-event-map, though the variable
supports only a subset of them. Do you have a better name in mind?
signature.asc
Description: OpenPGP digital signature