Re: [PATCH] GnuTLS support on Woe32

[Ted Zlatanov]

On Wed, 4 May 2011 05:25:07 +0200 Juanma Barranquero <address@hidden> wrote: 

JB> 2011/5/4 Ted Zlatanov <address@hidden>:
>> Could you push it into the :dll property of that symbol (always a list)?
>> Then just loop on all the names when logging later.

JB> What I've done is to add a property :loaded-from to the library-id
JB> (the symbol identifying the library). So in case the loading fails, I
JB> just log that it failed, but not the filenames that were tried,
JB> because they are exactly (cdr (assq 'gnutls dynamic-library-alist)).
JB> If the loading is successfull, I log the filename too.

That looks great, thanks for fixing it.

>> You could just say GNUTLS_LOG2 (1, 1, "loading the GnuTLS DLL: ",
>> filename) so it's unconditional (not the end of the world)

JB> I've opted for the easiest option, so GNUTLS_LOG2 (1, 1, ...). Feel
JB> free to change it once installed.

JB> Attached is the third version of the patch.

Everything looks OK to me.  I'll put some ERT tests on gnutls.el on my
TODO list (though anyone should feel free to do it) so we can test a few
of the connection cases.

Thanks
Ted