emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Move sha1 to C?


From: Leo
Subject: Re: Move sha1 to C?
Date: Mon, 23 May 2011 16:44:53 +0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3.50 (Mac OS X 10.6.7)

On 2011-05-23 09:23 +0800, Stefan Monnier wrote:
> Fine by me.  3 should also include "gut sha1.el's content" so that
> loading it won't end up overwriting the C implementation with the old
> Elisp code.

In the patch attached in last post, feature sha1 is provided so
(require 'sha1) should not load sha1.el but if people insist in using
(load "sha1") then the primitive is overwritten. I hope this is OK.

>
>> Should the signature of sha1 stay as is or change to be similar to md5?
>>    (md5 OBJECT &optional START END CODING-SYSTEM NOERROR)
>
> I don't have any opinion on this.  The only thing I consider important
> is to signal an error if the hashed text contains any
> non-byte character.

OK.

Leo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]