[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] rcirc: support TLS/SSL and arbitrary connection method
From: |
Stefan Monnier |
Subject: |
Re: [PATCH] rcirc: support TLS/SSL and arbitrary connection method |
Date: |
Mon, 30 May 2011 22:24:53 -0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
> I'm writing you to submit a patch for rcirc.el to give it support for
> SSL connections.
Thank you. But I'm afraid you're just a few weeks late:
revno: 104199
committer: Stefan Monnier <address@hidden>
branch nick: trunk
timestamp: Wed 2011-05-11 23:25:58 -0300
message:
* lisp/net/rcirc.el: Add support for SSL/TLS connections.
(rcirc-server-alist): New field `encryption'.
(rcirc): Check `encryption' settings.
(rcirc-connect): New arg `encryption'. Use open-network-stream.
Merge make-local-variable into `set'.
(rcirc--connection-open-p): New function.
(rcirc-send-string, rcirc-clean-up-buffer): Use it to handle case where
the process is not a network process (e.g. running gnutls-cli).
(set-rcirc-decode-coding-system, set-rcirc-encode-coding-system):
Make rcirc-(en|de)code-coding-system local here.
(rcirc-mode): Merge make-local-variable into `set'.
(rcirc-parent-buffer): Make permanent buffer-local.
(rcirc-multiline-minor-mode): Don't do it here.
(rcirc-switch-to-server-buffer): Don't switch to a random buffer if
there's no server buffer.
> The last 2 chunks of the patch are meant to strip the IRC colors.
> Not really part of the "connection" patch, but IMHO useful.
Could you describe a bit more what this is about (I'm not a regular IRC
user)? I can't remember seeing those C-c escape sequences, when do they
appear, what are they expected to do? Should we really strip them, or
would it be even better to turn them into faces?
> In case you're interested, I signed the Emacs papers some years ago.
If you could send a new patch based on the latest code to provide the
remaining features, I'd be happy to install it.
Stefan