[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: org-src.el begin_src/end_src fontification may have been broken rece

From: Ted Zlatanov
Subject: Re: org-src.el begin_src/end_src fontification may have been broken recently
Date: Fri, 10 Jun 2011 11:23:44 -0500
User-agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux)

On Thu, 09 Jun 2011 19:20:24 -0500 Ted Zlatanov <address@hidden> wrote: 

TZ> On Tue, 07 Jun 2011 10:54:28 -0500 Ted Zlatanov <address@hidden> wrote: 
TZ> Recently (I haven't been able to find the commit that did it) org-src.el
TZ> fontification broke.  I get an error that ":-mode" could not be
TZ> executed.

TZ> Tha attached patch fixes the problem, which is that the fontification
TZ> language is now in position 8 instead of 7, and position 7 has ":".  The
TZ> fix is purely a patch, not really addressing why position 7 now has ":"
TZ> when it was the language before (there have been no commits to org.el
TZ> that could have caused this bug, AFAICT).  So something in this regular
TZ> expression:

TZ> "^\\([ \t]*#\\+\\(\\([a-zA-Z]+:?\\| \\|$\\)\\(_\\([a-zA-Z]+\\)\\)?\\)[ 
\t]*\\(\\([^ \t\n]*\\)[ \t]*\\(.*\\)\\)\\)"

TZ> broke between May 28 or so and today.  Which is why I made the fix as I
TZ> did, so it would keep working in places where the breakage doesn't
TZ> happen.

Sometimes it takes days of debugging and a full patch to see the
problem: Julien Danjou is using begin/end tags like this:

#+begin_src: emacs-lisp

While I'm using (as I was shown by Julien)

#+begin_src lisp

TZ> I'd really appreciate it if someone could review and maybe commit this
TZ> patch on the Emacs side (or I can commit it if necessary).  I don't
TZ> think it's an org-mode issue, but it could be breaking other people's
TZ> setups too because it triggers during fontification.

Julien, are you using that extra ":" because it's legitimate?  Or is it
an accident?  What should I do with my patch?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]